Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Examples: Improve webgpu_postprocessing_ssr. #29878

Merged
merged 2 commits into from
Nov 14, 2024
Merged

Examples: Improve webgpu_postprocessing_ssr. #29878

merged 2 commits into from
Nov 14, 2024

Conversation

Mugen87
Copy link
Collaborator

@Mugen87 Mugen87 commented Nov 14, 2024

Related issue: -

Description

The PR makes the WebGPU SSR demo more attractive by introducing a new asset and scene settings.

@Mugen87 Mugen87 added this to the r171 milestone Nov 14, 2024
@Mugen87 Mugen87 merged commit 651280b into mrdoob:dev Nov 14, 2024
6 of 7 checks passed
@sunag
Copy link
Collaborator

sunag commented Nov 15, 2024

It’s really beautiful to see the reflections now.

@ligaofeng0901
Copy link
Contributor

ligaofeng0901 commented Nov 21, 2024

The refelction looks nice, but It seems that it still doesn't work correctly with logarithmicDepthBuffer,
With logarithmicDepthBuffer on, I got this effect:
image
And I tried to change
https://github.com/mrdoob/three.js/blob/dev/examples/jsm/tsl/display/SSRNode.js#L142
to logarithmicDepthToViewZ, it is still not correct.

@mrdoob
Copy link
Owner

mrdoob commented Dec 20, 2024

While improving the example (98170ef) I noticed that the materials in the model have side set to DoubleSide.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants