Prerender buffer for transmissive objects #22595
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mugen87
reviewed
Oct 12, 2021
Mugen87
reviewed
Oct 12, 2021
| @@ -1249,15 +1265,15 @@ function WebGLRenderer( parameters = {} ) { | |||
|
|
|||
| } | |||
|
|
|||
| function renderScene( currentRenderList, scene, camera, viewport ) { | |||
| function renderScene( currentRenderList, scene, camera, viewport, renderTransmissiveObjects ) { | |||
There was a problem hiding this comment.
What is the reason for pre-rendering the buffer for transmissive objects only for the XR code path? Couldn't the renderer always use this approach (so for non-XR setups, too).
There was a problem hiding this comment.
No particular reason. I didn't want to change the non-xr path.
There was a problem hiding this comment.
Okay, I see. I just wonder if the change becomes simpler if we have a uniform transmission code path.
@mrdoob What do you think?
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue: #22594
This contribution is funded by Oculus.