GLTFLoader: Modified Spec Gloss shader to match the glTF spec #20226
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/cc @elalish |
|
Hi @WestLangley, Thanks for the fix! I don't remember why I changed so... I guess I have misread your comment? #10985 (comment) |
|
@takahirox I think I see the confusion... The diffuse reflectance of the material does not change, but the amount of light available to be diffusely reflected is reduced. Rather than scaling the irradiance, the reflectance is scaled instead. That is a bit confusing, but it seems to be done that way a lot. |
|
Thanks @WestLangley! |
|
Thanks! |
|
@donmccurdy Just a heads-up that this has been merged... I am aware there has been a lot of discussion about this approximation. This PR is just adhering to the current spec. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR modifies the shader to match the glTFSpec.
The shader previously matched the spec, but it was changed in 8360b53. /ping @takahirox
The model in the spec is an approximation, but it is far superior to what is currently implemented here. For example, if specular is [1, 1, 1], there can be no light reflected diffusely.
/ping @donmccurdy