GLTFExporter: Support SpecularGlossiness materials #17127
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
donmccurdy
reviewed
Jul 30, 2019
donmccurdy
reviewed
Aug 8, 2019
donmccurdy
approved these changes
Aug 14, 2019
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request enables support for exporting spec/gloss PBR materials. It is based on another closed pull request (#16413) with some modifications and matching the styleguide.
It fixes #15351. Here there are some models that were exporting without materials but are now working:
https://sketchfab.com/models/c438e81e796d41d9a6ae4cc147ef8d4f
https://sketchfab.com/models/fb847d79fdfa465894f30475c6cfbf05
https://sketchfab.com/models/f5abe05ff2124527a6871060b2809bb2
https://sketchfab.com/models/58e93896d1a14eb9af7b776272a48ed6