[glTF] Implement glTF2.0 common materials, clean up loadMaterials(). #11485
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
loadMaterials()
a bit.All currently-supported examples work as before. I don't have official examples for common materials or lights yet, but went ahead and updated the Duck model using the blender extension.
Sorry that the diff is unreadable...
loadMaterials
needed a bit of un-nesting. The gist of the changes' structure is shown here:https://github.com/donmccurdy/three.js/blob/fb2066bb899f55d4a9ddf519cf4d0298e99aafca/examples/js/loaders/GLTF2Loader.js#L1914-L1934
/cc @takahirox