Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix Object3D.remove multi-object bug #11482

Merged
merged 2 commits into from
Jun 10, 2017
Merged

fix Object3D.remove multi-object bug #11482

merged 2 commits into from
Jun 10, 2017

Conversation

06wj
Copy link
Contributor

@06wj 06wj commented Jun 10, 2017

Need return when the parameter is multiple.

mrdoob
mrdoob reviewed Jun 10, 2017
View reviewed changes
src/core/Object3D.js Outdated
@@ -356,6 +356,8 @@ Object.assign( Object3D.prototype, EventDispatcher.prototype, {

}

return;
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more. 

return this;

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok, added.

@mrdoob mrdoob merged commit ef4844b into mrdoob:dev Jun 10, 2017
@mrdoob
Copy link
Owner

mrdoob commented Jun 10, 2017

Thanks!

@06wj 06wj deleted the patch-remove branch June 10, 2017 01:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mrdoob mrdoob mrdoob left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@06wj @mrdoob