use scene.background in webgl_nearestneighbour example #11413
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WestLangley
reviewed
May 29, 2017
examples/webgl_nearestneighbour.html
Outdated
| @@ -182,51 +187,58 @@ | |||
| controls.handleResize(); | |||
| } | |||
|
|
|||
| function animate() { | |||
| function animate () { | |||
There was a problem hiding this comment.
Thanks for the code cleanup, but according to mrdoobapproves and this comment, the whitespace pattern should be one of:
function animate() {
}
var animate = function () {
};
|
fixed I think, unless I've missed something else. |
Mugen87
approved these changes
May 30, 2017
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
use scene.background and a CubeTexture instead of a manually made skybox.
whitespace fixes.