Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Example misc_animation_keys: add color keyframe and clean up #11410

Merged
merged 1 commit into from
May 30, 2017
Merged

Example misc_animation_keys: add color keyframe and clean up #11410

merged 1 commit into from
May 30, 2017
+20 −20

Conversation

WestLangley
Copy link
Collaborator

No description provided.

@looeee
Copy link
Collaborator

looeee commented May 29, 2017

Oh, nice! Does the color keyframe work? I was going from the (slightly cryptic!) note in the docs:

The very basic implementation of this subclass has nothing special yet. However, this is the place for color space parameterization.

and assuming that it hadn't been implemented yet.

@WestLangley
Copy link
Collaborator Author

@looeee It works. You were trying to use hex for colors.

@mrdoob mrdoob merged commit e59bf9d into mrdoob:dev May 30, 2017
@mrdoob
Copy link
Owner

mrdoob commented May 30, 2017

Thanks!

@WestLangley WestLangley deleted the dev-anim branch May 30, 2017 18:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mugen87 Mugen87 Mugen87 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@WestLangley @looeee @mrdoob @Mugen87