Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve the ArrayBuffer/String converting performance with TextDecoder #11355

Merged
merged 2 commits into from
May 17, 2017
Merged

Improve the ArrayBuffer/String converting performance with TextDecoder #11355

merged 2 commits into from
May 17, 2017

Conversation

takahirox
Copy link
Collaborator

@takahirox takahirox commented May 17, 2017 •
edited by mrdoob
Loading

This PR improves the .load() performance 70x (if we ignore network speed)
of the following loaders by using TextDecoder.decode()

#11287

  • FBXLoader
  • GLTF(2)Loader
  • PCDLoader
  • PLYLoader
  • STLLoader
  • XLoader

And I tuned a bit for browsers(IE and Edge) which don't support TextDecoder yet.

@mrdoob
Copy link
Owner

mrdoob commented May 17, 2017

Sweet!

@mrdoob mrdoob merged commit 49fd9f6 into mrdoob:dev May 17, 2017
@mrdoob
Copy link
Owner

mrdoob commented May 17, 2017

Many thanks!

@takahirox takahirox deleted the TextDecoder branch May 17, 2017 23:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@takahirox @mrdoob