Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix an offset bug in BinaryLoader #11352

Merged
merged 1 commit into from
May 17, 2017
Merged

Fix an offset bug in BinaryLoader #11352

merged 1 commit into from
May 17, 2017
+1 −1

Conversation

takahirox
Copy link
Collaborator

This PR fixes an offset bug in BinaryLoader.

offset is already applied to charArray when it's created so
I don't think offset should be applied to charArray index.

@mrdoob
Copy link
Owner

mrdoob commented May 17, 2017

Oh, how did you find this?

@takahirox
Copy link
Collaborator Author

By running grep fromCharCode under examples/js/loaders
to make PR for #11287

@mrdoob
Copy link
Owner

mrdoob commented May 17, 2017

I see I see... Yeah, seems like that function is only called once and offset is always 0.

@mrdoob mrdoob merged commit 9c6b7a9 into mrdoob:dev May 17, 2017
@mrdoob
Copy link
Owner

mrdoob commented May 17, 2017

Thanks!

@takahirox takahirox deleted the FixBinaryLoader branch May 17, 2017 03:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@takahirox @mrdoob