Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OBJLoader: Allow flat and smooth shading within the same material definition for a specific object #11343

Merged
merged 2 commits into from
May 25, 2017
Merged

OBJLoader: Allow flat and smooth shading within the same material definition for a specific object #11343

merged 2 commits into from
May 25, 2017

Conversation

kaisalmen
Copy link
Contributor

@kaisalmen kaisalmen commented May 15, 2017 •
edited by Mugen87
Loading

Fixed #11270.

kaisalmen added 2 commits May 15, 2017 23:46
@kaisalmen
mrdoob#11270 OBJLoader assigns flat shading if smoothing group is def…
bd3eda3 
…ined as 0 or off. All other values lead to smooth shading
@kaisalmen
mrdoob#11270 Hand made OBJ files with two simple cubes: Test proper M…
af86519 
…esh creation from "o" and "g" definitions, plus Multi-Material creation from different "s" definitions
@mrdoob
Copy link
Owner

mrdoob commented May 22, 2017

@jonnenauha looks good?

@mrdoob mrdoob changed the title Issue11270 OBJLoader: Allow flat and smooth shading within the same material definition for a specific object May 22, 2017
@jonnenauha
Copy link
Contributor

yeah lgtm

@mrdoob mrdoob merged commit 7ba811c into mrdoob:dev May 25, 2017
@mrdoob
Copy link
Owner

mrdoob commented May 25, 2017

Thanks!

@kaisalmen kaisalmen deleted the Issue11270 branch May 25, 2017 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Problem with smoothing groups in OBJ files
3 participants
@kaisalmen @mrdoob @jonnenauha