Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EffectComposer: Added dependency check #11263

Merged
merged 1 commit into from
May 14, 2017
Merged

EffectComposer: Added dependency check #11263

merged 1 commit into from
May 14, 2017

Conversation

Mugen87
Copy link
Collaborator

@Mugen87 Mugen87 commented Apr 30, 2017 •
edited
Loading

This PR addressed #3865.

EffectComposer now logs an error if THREE.ShaderPass is missing.

@Mugen87
Copy link
Collaborator Author

Mugen87 commented Apr 30, 2017

We don't need to check MaskPass because of this line.

@Mugen87 Mugen87 changed the title EffectComposer: Added dependency error EffectComposer: Added dependency check Apr 30, 2017
@Mugen87
Copy link
Collaborator Author

Mugen87 commented May 9, 2017

Is it okay to merge this one? I was asked several times by colleagues why the dependency checks are incomplete at this place.

@mrdoob mrdoob merged commit 6010ca2 into mrdoob:dev May 14, 2017
@mrdoob
Copy link
Owner

mrdoob commented May 14, 2017

Many thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Mugen87 @mrdoob