Remove unnecessary "#include <specularmap_fragment>" from meshphysical_frag.glsl #11250
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes unnecessary
#include <specularmap_fragment>
frommeshphysical_frag.glsl
which is shader forMeshStandardMaterial
andMeshPhysicalMaterial
.If I'm right,
meshphysical_frag.glsl
doesn't need to includespecularmap_fragment
.specularmap_fragment.glsl
is a shader chunk forspecularStrength
.specularStrength
is used only inenvmap_fragment.glsl
andlights_phong_[pars_]fragment.glsl
butmeshphysical_frag.glsl
doesn't include them.