Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unnecessary "#include <specularmap_fragment>" from meshphysical_frag.glsl #11250

Merged
merged 2 commits into from
Apr 27, 2017

Conversation

takahirox
Copy link
Collaborator

@takahirox takahirox commented Apr 27, 2017

This PR removes unnecessary #include <specularmap_fragment> from meshphysical_frag.glsl which is shader for MeshStandardMaterial and MeshPhysicalMaterial.

If I'm right, meshphysical_frag.glsl doesn't need to include specularmap_fragment.

specularmap_fragment.glsl is a shader chunk for specularStrength.
specularStrength is used only in envmap_fragment.glsl and lights_phong_[pars_]fragment.glsl but
meshphysical_frag.glsl doesn't include them.

@mrdoob
Copy link
Owner

mrdoob commented Apr 27, 2017

@WestLangley looks good?

@WestLangley
Copy link
Collaborator

WestLangley commented Apr 27, 2017

Yes, that can be removed.

#include <specularmap_pars_fragment> in the vertex shader can also be removed, I expect.

Please confirm. Thanks.

@takahirox
Copy link
Collaborator Author

Yup, seems like we also can remove it.
Confirmed and updated.

@mrdoob mrdoob merged commit d57cbd5 into mrdoob:dev Apr 27, 2017
@mrdoob
Copy link
Owner

mrdoob commented Apr 27, 2017

Thanks!

@takahirox takahirox deleted the FixStandardShader branch April 27, 2017 22:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants