-
-
Notifications
You must be signed in to change notification settings - Fork 35.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove ESM Node support mention from the installation doc #19830
Comments
Perhaps a good time would be once 14 becomes LTS (in October I think) ? |
Yeah, that makes sense. I'll ping this issue when it does. |
It might also be necessary to use older versions of node until headless-gl has a prebuilt binary for v14. Building it from source has been iffy for me, and a WebGL alternative is important for three.js. |
People are likely to be using Node v12 for at least another few years, judging from previous Node releases. We could change the paragraph:
|
Sorry for asking but you say nothing special is required. I have just upgrade to node node utils/converters/obj2three.js examples/models/obj/emerald.obj I still get:
It works if I modify the package.json. But it appears it does not "just work". |
@Mugen87 I think (but I might be wrong) that that's expected - that it is a Node thing. Similarly to how in browser JavaScript when you want to use ESM, you need to use |
Okay, thanks for the clarification. I think the documentation should reflect this since many users (especially beginners) will do the same (naive) thing I did^^. So it should at least mention that it's required to configure |
It's true, I will patch this PR to include this when I have a chance. |
I think this is an issue, not a PR 😇 . |
Oh yeah, sorry, I have an associated PR for this somewhere. |
Related: #18498 |
I guess this can be closed then? |
TBH, I don't feel strong about this. I suggested #19830 (comment) but one could also argue that it's not the task of the |
Closing for now. |
Citing from https://threejs.org/docs/#manual/en/introduction/Installation:
As of latest Node (14.5.0 at the time of writing), ESM support in Node works as expected and nothing special is required (like using CLI flags or MJS extension). Therefore I would like to discuss whether it's appropriate to remove this section of the document.
If it is deemed so, I'll be happy to send in a PR removing it or rewording it.
The text was updated successfully, but these errors were encountered: