Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable less tests on php 7.4+ #685

Merged
merged 1 commit into from
Mar 11, 2021
Merged

Disable less tests on php 7.4+ #685

merged 1 commit into from
Mar 11, 2021

Conversation

glensc
Copy link
Collaborator

@glensc glensc commented Dec 1, 2020

marcusschwarz/lesserphp needs updating

1) Minify\Test\LessSourceTest::testLessTimestamp
Array and string offset access syntax with curly braces is deprecated
/home/travis/build/mrclay/minify/vendor/marcusschwarz/lesserphp/lessc.inc.php:761
/home/travis/build/mrclay/minify/lib/Minify/LessCssSource.php:122
/home/travis/build/mrclay/minify/lib/Minify/LessCssSource.php:73
/home/travis/build/mrclay/minify/lib/Minify/LessCssSource.php:34
/home/travis/build/mrclay/minify/lib/Minify/HTML/Helper.php:155
/home/travis/build/mrclay/minify/lib/Minify/HTML/Helper.php:134
/home/travis/build/mrclay/minify/lib/Minify/HTML/Helper.php:51
/home/travis/build/mrclay/minify/tests/LessSourceTest.php:38

and that is out of our control:

@glensc glensc self-assigned this Dec 1, 2020
@glensc glensc merged commit 40f9daf into master Mar 11, 2021
@glensc glensc deleted the php-8 branch March 11, 2021 11:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant