Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix support for php 7.4 #677

Merged
merged 4 commits into from
Oct 24, 2020
Merged

Fix support for php 7.4 #677

merged 4 commits into from
Oct 24, 2020

Conversation

glensc
Copy link
Collaborator

@glensc glensc commented Jul 12, 2020

requires external dependency to be fixed first:

@glensc glensc self-assigned this Jul 12, 2020
@glensc glensc mentioned this pull request Oct 23, 2020
@glensc
Copy link
Collaborator Author

glensc commented Oct 24, 2020

keeping 7.4 in allow failure to be able to merge

@glensc glensc marked this pull request as ready for review October 24, 2020 15:53
@glensc glensc merged commit efec972 into master Oct 24, 2020
@glensc glensc deleted the php-7.4 branch October 24, 2020 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant