Exclude SSI Comments from HTML minify #670
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
March 31, 2020 15:43
Exclude Nginx & Apache Server Side Include (SSI) comments from being stripped via minification, the same way IE directives are not stripped. Both Nginx & Apache SSI directives begin with: <!—# So we can just look for the # and don’t strip the comment in that case. Nginx SSI: http://nginx.org/en/docs/http/ngx_http_ssi_module.html Apache SSI: https://httpd.apache.org/docs/2.4/howto/ssi.html
Exclude Nginx & Apache Server Side Include (SSI) comments from being stripped via minification, the same way IE directives are not stripped. Both Nginx & Apache SSI directives begin with: <!--# So we can just look for the # and don’t strip the comment in that case. Nginx SSI: http://nginx.org/en/docs/http/ngx_http_ssi_module.html Apache SSI: https://httpd.apache.org/docs/2.4/howto/ssi.html
Closed
|
Can you try to add some testcases? |
|
Done @glensc ! |
|
Can you squash or reword commits, currently two commits with the same commit message looks weird. Or I'll squash the whole changeset to one commit myself using GitHub Web? |
|
@glensc yeah if you want to squash the whole changeset, I think that makes the most sense. Appreciate you working with me on this, I'm hoping to get it tagged & released so I can update the dependency in my plugin: https://github.com/nystudio107/craft-minify |
|
Awesome, many thanks @glensc |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Exclude Nginx & Apache Server Side Include (SSI) comments from being stripped via minification, the same way IE directives are not stripped.
Both Nginx & Apache SSI directives begin with:
So we can just look for the # and don’t strip the comment in that case.
Nginx SSI: http://nginx.org/en/docs/http/ngx_http_ssi_module.html
Apache SSI: https://httpd.apache.org/docs/2.4/howto/ssi.html
Resolves: #671