Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use %in% to compare strings to gracefully deal with NAs #124

Merged
merged 1 commit into from
Aug 20, 2024

Conversation

sangeetabhatia03
Copy link
Collaborator

filter_df_for_metamean was creating rows with all NAs because we used == to compare the column paramter_value_type with Mean/Median etc. Where the column itself was NA, using == led to NA instead of a logical. I have now fixed this so that we use %in% operator to compare strings.

  • [ NA] I have added new dependencies in DESCRIPTION
  • [ X] I have bumped the version number in DESCRIPTION
  • [X ] I have updated the NEWS.md
  • [ X] I have added unit tests using testthat
  • [ X] I have checked that the package can install locally using devtools::install_local("<path-to-epireview>")
  • [ NA] I have added documentation where required
  • [ NA] My documentation includes examples of how to use the function
  • [NA ] If necessary, I have updated priority-pathogens

Copy link
Collaborator

@CosmoNaught CosmoNaught left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM + passes tests. Merging

@CosmoNaught CosmoNaught merged commit 7fd9908 into develop Aug 20, 2024
5 checks passed
@sangeetabhatia03 sangeetabhatia03 deleted the fix-117 branch August 20, 2024 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants