Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix 104 #109

Merged
merged 2 commits into from
Jul 22, 2024
Merged

Fix 104 #109

merged 2 commits into from
Jul 22, 2024

Conversation

sangeetabhatia03
Copy link
Collaborator

This PR fixes #104; I am now using readr to read in the mapping from parameter names to short parameter names.

Checklist:

  • [X ] I have added new dependencies in DESCRIPTION
  • [X ] I have bumped the version number in DESCRIPTION
  • [ X] I have updated the NEWS.md
  • [ NA] I have added unit tests using testthat
  • [ NA] I have checked that the package can install locally using devtools::install_local("<path-to-epireview>")
  • [ NA] I have added documentation where required
  • [ NA] My documentation includes examples of how to use the function
  • [ NA] If necessary, I have updated priority-pathogens

Copy link
Collaborator

@CosmoNaught CosmoNaught left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Passes tests and checks, all good.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Propose that perhaps @sangeetabhatia03 if we have varying delimiters we move all read_csv() to read_delim() so that we can handle multiple delimiters without coding for exceptions. Not urgent, but relates to lowering our dependency footprint and variability in function convention.

@CosmoNaught CosmoNaught merged commit 97ca8ef into develop Jul 22, 2024
5 checks passed
@CosmoNaught CosmoNaught deleted the fix-104 branch July 22, 2024 20:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants