Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix typos and inaccuracies, update version and pub location #89

Merged
merged 1 commit into from
Jan 12, 2025
Merged

fix typos and inaccuracies, update version and pub location #89

merged 1 commit into from
Jan 12, 2025

Conversation

m-murphy
Copy link
Collaborator

@m-murphy m-murphy commented Jan 7, 2025 •
edited
Loading

Pull Request for PGEforge

Thank you for your contribution to PGEforge!✨

Description of changes

Fixing various problems in the moire tutorial

Pull Request Checklist

  • I have provided a description and detailed information about the changes made
  • I have followed the PGEforge GitHub contribution guidelines and I am merging into the develop branch
  • Documentation is updated, if necessary
  • Relevant issues are linked, if applicable

@m-murphy m-murphy marked this pull request as ready for review January 7, 2025 20:31
@m-murphy m-murphy linked an issue Jan 8, 2025 that may be closed by this pull request
MOIRE tutorial has innaccuracies #88
Closed
shaziaruybal
shaziaruybal approved these changes Jan 12, 2025
View reviewed changes
Copy link
Collaborator

@shaziaruybal shaziaruybal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @m-murphy for updating!

@shaziaruybal shaziaruybal merged commit a394506 into develop Jan 12, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kathryn1995 kathryn1995 kathryn1995 approved these changes

@shaziaruybal shaziaruybal shaziaruybal approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

MOIRE tutorial has innaccuracies
3 participants
@m-murphy @shaziaruybal @kathryn1995