Skip to content

Commit

Permalink
[helm loki/promtail] make UpdateStrategy configurable (grafana#1898)
Browse files Browse the repository at this point in the history
This commit makes UpdateStrategy of the promtail daemonset configurable.
On large installations, you may want to increase the value of maxUnavailable.

This fixes grafana#1878
  • Loading branch information
Stefan Andres authored Apr 6, 2020
1 parent fced874 commit 5eedfd2
Show file tree
Hide file tree
Showing 4 changed files with 9 additions and 7 deletions.
2 changes: 1 addition & 1 deletion production/helm/loki-stack/Chart.yaml
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
apiVersion: "v1"
name: loki-stack
version: 0.34.0
version: 0.34.1
appVersion: v1.4.0
kubeVersion: "^1.10.0-0"
description: "Loki: like Prometheus, but for logs."
Expand Down
2 changes: 1 addition & 1 deletion production/helm/promtail/Chart.yaml
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
apiVersion: "v1"
name: promtail
version: 0.20.0
version: 0.20.1
appVersion: v1.4.0
kubeVersion: "^1.10.0-0"
description: "Responsible for gathering logs and sending them to Loki"
Expand Down
5 changes: 1 addition & 4 deletions production/helm/promtail/templates/daemonset.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -16,10 +16,7 @@ spec:
app: {{ template "promtail.name" . }}
release: {{ .Release.Name }}
updateStrategy:
type: {{ .Values.deploymentStrategy }}
{{- if ne .Values.deploymentStrategy "RollingUpdate" }}
rollingUpdate: null
{{- end }}
{{- toYaml .Values.deploymentStrategy | nindent 4 }}
template:
metadata:
labels:
Expand Down
7 changes: 6 additions & 1 deletion production/helm/promtail/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,12 @@ affinity: {}

annotations: {}

deploymentStrategy: RollingUpdate
# The update strategy to apply to the DaemonSet
##
deploymentStrategy: {}
# rollingUpdate:
# maxUnavailable: 1
# type: RollingUpdate

initContainer:
enabled: false
Expand Down

0 comments on commit 5eedfd2

Please sign in to comment.