some improvements for the helm chart #45
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello mr-karan,
First of all I want to thank you for creating and maintaining this wonderful tool!
I took the time to customize the Helm chart previously updated by @weibo-zhao.
Currently when deploying, "prod_alerts" and "dev_alerts" are always added to the configuration and initialised in Calert.
You can change the individual values of the provider but you are tied to the names "prod_alerts" and "dev_alerts"
Below I will briefly describe my changes:
I am currently struggling with an issue regarding the second change
Let us look at it with the following scenario:
Using my Helm chart, we configured two providers, both using google_chat for notification.
Calert always seems to be expecting a message.tmpl file and cannot process a different name (text.tmpl in this case).
Am i missing something or is this behavior intentional? 🤔
Despite the mentioned issue, the deployment of Calert, the creation of different providers and templates still works!
For now, people using this changes just have to stick to the default template name "message.tmpl" (template = "static/message.tmpl").
I look forward reading your opinion on this PR
Thanks in advance!