Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

@AsciiDoc: Complete string is omitted #411

Closed
suddenfall opened this issue May 17, 2023 · 3 comments · Fixed by #413
Closed

@AsciiDoc: Complete string is omitted #411

suddenfall opened this issue May 17, 2023 · 3 comments · Fixed by #413

Comments

@suddenfall
Copy link
Contributor

The complete string is omitted, when two anchors [[...]] are used in the same line. I guess the corresponding regex is greedy but should not be greedy.

Here is an example to test it:
bug2.zip
@jnavila
Copy link
Collaborator

jnavila commented May 19, 2023

Ha. This one is wicked. The bug is only triggered if there are anchors at the beginning and the end of the line. Then, the line is mis-interpreted as a styling stanza.

Will propose a patch soon.

jnavila added a commit to jnavila/po4a that referenced this issue May 19, 2023
@jnavila
Fix the handling of block ids in asciidoc files.
c3c75c9 
When block ids are used inline, they must not be confused with
styling directives.  This is done by checking that the content of the
styline directive does not contain an ending square bracket.

Fixes mquinson#411
@jnavila jnavila mentioned this issue May 19, 2023
Merged
@jnavila
Copy link
Collaborator

jnavila commented May 19, 2023

BTW, thank you very much for the minimal reproducing set up. This is perfect for debugging!

@suddenfall
Copy link
Contributor Author

I'm also an engineer and author of a few tiny open source projects. I know that a good bug report is half the bug fix.

mquinson pushed a commit that referenced this issue May 22, 2023
@jnavila @mquinson
Fix the handling of block ids in asciidoc files.
8dc17c7 
When block ids are used inline, they must not be confused with
styling directives.  This is done by checking that the content of the
styline directive does not contain an ending square bracket.

Fixes #411
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix the handling of block ids in asciidoc files. jnavila/po4a
2 participants
@jnavila @suddenfall