asciidoc: manage empty cells in tablecells option

fixes #343
mquinson · Dec 23, 2021 · 85403ec · 85403ec
1 parent 7fe0be4
commit 85403ec
Show file tree

Hide file tree

Showing 7 changed files with 48 additions and 1 deletion.
diff --git a/NEWS b/NEWS
@@ -9,6 +9,9 @@ __   __/ _ \ / /_  / /_
   \_/  \___(_)___/ \___/          (unreleased)
 
 
+Asciidoc:
+ * Support empty cells in tablecells mode (GitHub's #343 - J.N. Avila)
+
 Yaml:
  * New option "paths" to select the full paths to extract.
    The old "key" option (that allows to select any path ending with

diff --git a/lib/Locale/Po4a/AsciiDoc.pm b/lib/Locale/Po4a/AsciiDoc.pm
@@ -461,7 +461,9 @@ sub parse {
             shift @texts;
             my @parts = map { ( $_, shift @texts ) } @seps;
             foreach my $part (@parts) {
-                if ( !$part ) { next }
+                if ( not defined $part ) {
+					# allows concatenation and will be stripped anyway
+					$part = " "; }
                 if ( $part =~ /\|$/ ) {
 
                     # this is a cell separator. End the previous cell

diff --git a/t/fmt/asciidoc/TablesCells.adoc b/t/fmt/asciidoc/TablesCells.adoc
@@ -139,3 +139,9 @@ I am a paragraph styled with the lead attribute.
 [.lead]
 I am a paragraph styled with the lead attribute.
 |===
+
+.Empty cells
+|===
+|0|
+||
+|===
diff --git a/t/fmt/asciidoc/TablesCells.norm b/t/fmt/asciidoc/TablesCells.norm
@@ -139,3 +139,9 @@ I am a paragraph styled with the lead attribute.
 [.lead]
 I am a paragraph styled with the lead attribute.
 |===
+
+.Empty cells
+|===
+|0| 
+| | 
+|===
diff --git a/t/fmt/asciidoc/TablesCells.po b/t/fmt/asciidoc/TablesCells.po
@@ -392,3 +392,15 @@ msgstr ""
 "\n"
 "[.LEAD]\n"
 "I AM A PARAGRAPH STYLED WITH THE LEAD ATTRIBUTE."
+
+#. type: Block title
+#: TablesCells.adoc:143
+#, no-wrap
+msgid "Empty cells"
+msgstr "EMPTY CELLS"
+
+#. type: Table
+#: TablesCells.adoc:145
+#, no-wrap
+msgid "0"
+msgstr "0"
diff --git a/t/fmt/asciidoc/TablesCells.pot b/t/fmt/asciidoc/TablesCells.pot
@@ -365,3 +365,15 @@ msgid ""
 "[.lead]\n"
 "I am a paragraph styled with the lead attribute."
 msgstr ""
+
+#. type: Block title
+#: TablesCells.adoc:143
+#, no-wrap
+msgid "Empty cells"
+msgstr ""
+
+#. type: Table
+#: TablesCells.adoc:145
+#, no-wrap
+msgid "0"
+msgstr ""
diff --git a/t/fmt/asciidoc/TablesCells.trans b/t/fmt/asciidoc/TablesCells.trans
@@ -139,3 +139,9 @@ I AM A PARAGRAPH STYLED WITH THE LEAD ATTRIBUTE.
 [.LEAD]
 I AM A PARAGRAPH STYLED WITH THE LEAD ATTRIBUTE.
 |===
+
+.EMPTY CELLS
+|===
+|0| 
+| | 
+|===
-Original file line number
+Diff line change
@@ Expand Up / @@ -139,3 +139,9 @@ I am a paragraph styled with the lead attribute. @@
     [.lead]
     I am a paragraph styled with the lead attribute.
     |===
+    .Empty cells
+    |===
+    |0|
+    ||
+    |===