Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MqttClient.reconnecting has no default value #1674

Closed
davdeo opened this issue Aug 18, 2023 · 2 comments
Closed

MqttClient.reconnecting has no default value #1674

davdeo opened this issue Aug 18, 2023 · 2 comments

Comments

@davdeo
Copy link
Contributor

davdeo commented Aug 18, 2023

After calling mqtt.connect(brokerUrl, options) the returned MqttClient has no default value for reconnecting (it is undefined).
Is this intentional? If yes why isn't the type something like: reconnecting: boolean | undefined?
@robertsLando
Copy link
Member

could be a type issue, PR?

davdeo pushed a commit to davdeo/MQTT.js that referenced this issue Aug 23, 2023
@cf-david-m
fix: Add default value false for reconnecting in constructor (mqttjs#…
c213738 
…1674)
@davdeo
Copy link
Contributor Author

davdeo commented Aug 23, 2023

I guess the problem was that the default value was not set in the constructor.

#1678

robertsLando added a commit to davdeo/MQTT.js that referenced this issue Aug 29, 2023
@robertsLando
Merge branch 'main' into mqttjs#1674
2d17b2d
robertsLando added a commit that referenced this issue Aug 30, 2023
@davdeo @cf-david-m @robertsLando
fix: set default value false for reconnecting in constructor (#1674) (#…
312b57b 
…1678)

Co-authored-by: david.monz <david.monz@cloudflight.io>
Co-authored-by: Daniel Lando <daniel.sorridi@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@robertsLando @davdeo