options/path: only log mp_get_user_path if the path expands #15880
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kasper93
reviewed
Feb 16, 2025
fd3f697 to
52cc877
Compare
|
Download the artifacts for this pull request: |
52cc877 to
f8e1541
Compare
Having path -> path in the log is kind of useless. If someone happens to call this on memory://, it will also flood the log with garbage. Only log it if the path actually gets expanded.
f8e1541 to
4419583
Compare
kasper93
approved these changes
Feb 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Having path -> path in the log is kind of useless. If someone happens to call this on memory://, it will also flood the log with garbage. Only print it at a debug level if the path actually changes/get expanded. Otherwise set it at trace.