-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
clipboard: add --clipboard-backends option #15870
base: master
Are you sure you want to change the base?
Conversation
Download the artifacts for this pull request: |
I can't envision any priority list that's more than 2 backends "X,vo", even taking into account future backends for e.g. X11. It would be far simpler to implement a |
c3c3998
to
6dbd1bc
Compare
X11 backend won't be VO depedent, which means that mpv with a wayland VO window can use 3 backends: X11, Wayland, and VO. |
6dbd1bc
to
9ee8c3f
Compare
Elaborate? |
X11 backend can be used to access Xwayland clipboard, or the clipboard of some other X session (like from Xephyr/another VT). This can be done regardless if mpv VO window is Wanyland or X11, or even with no VO window at all. |
I can't think of any good practical reason to allow that. It's just another attack vector if mpv can access the X11 clipboard while having no VO or having a wayland VO active. A vo native clipboard backend should only be possible to be used if mpv has a VO window of the same backend. This is already the case for every backend except X11 due to platform limitations. |
It's only an option. I think it is good to have. And having it directly liked to implementation makes sense, instead of creating another list of pseudo-implementation names. Also this option makes |
7e3d92c
to
9fd2e8d
Compare
It's now removed, and updated |
9fd2e8d
to
7c13384
Compare
Thanks. Except one remaining comment, the change looks ok to me. |
cefa5f3
to
00f2e0e
Compare
This allows specifying a priority list of clipboard backends to use. This is mostly useful on Linux where multiple clipboard backends exist.
Clipboard can be now disabled with --clipboard-backends-clr so --clipboard-enable is redundant.
00f2e0e
to
46fad15
Compare
This allows specifying a priority list of clipboard backends to use. This is mostly useful on Linux where multiple clipboard backends exist.