Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

player: store external filenames as normalized #15853

Merged
merged 1 commit into from
Feb 17, 2025

Conversation

Dudemanguy
Copy link
Member

Instead of re-normalizing the external filenames of tracks anytime the property is read, store it normalized in the first place.

Copy link

github-actions bot commented Feb 12, 2025

Download the artifacts for this pull request:

Windows
macOS

@sfan5 sfan5 self-requested a review February 14, 2025 14:23
@kasper93
Copy link
Contributor

This is one case of annoyance, but also if you open something like memory://... it will get printed too, which may be quite a lot of data, unprintable too...

@Dudemanguy
Copy link
Member Author

mp_get_user_path should just not print anything if it doesn't expand the path. It's kind of dumb.

Instead of re-normalizing the external filenames of tracks anytime the
property is read, store it normalized in the first place.
@Dudemanguy
Copy link
Member Author

Since 23e1fb4, the logging something like memory:// shouldn't be a problem anymore.

@Dudemanguy Dudemanguy added this pull request to the merge queue Feb 17, 2025
Merged via the queue into mpv-player:master with commit 23b57e9 Feb 17, 2025
26 checks passed
@Dudemanguy Dudemanguy deleted the external-filename branch February 17, 2025 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants