Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

video/out/wayland: update color management protocol to the final upstream version #15720

Merged
merged 1 commit into from
Feb 17, 2025
Merged

video/out/wayland: update color management protocol to the final upstream version #15720

merged 1 commit into from
Feb 17, 2025
+114 −1,557

Conversation

Zamundaaa
Copy link
Contributor

linkmauve
linkmauve reviewed Jan 21, 2025
View reviewed changes
@Dudemanguy
Copy link
Member

Dudemanguy commented Jan 21, 2025 •
edited
Loading

The initialize_color_maps function can be deleted since the primaries/transfers don't include 0 in the final version.

kasper93
kasper93 reviewed Jan 21, 2025
View reviewed changes
@Zamundaaa Zamundaaa force-pushed the work/final-color branch 2 times, most recently from 51dc4d7 to c71fa21 Compare January 21, 2025 16:35
@Zamundaaa Zamundaaa force-pushed the work/final-color branch 2 times, most recently from 8ed3cf6 to 182b20d Compare January 29, 2025 17:37
@helixoid
Copy link

Wayland Protocol has been merged!

@returntoreality
Copy link

And the new protocols have now been released as well. This was a blocker for @Zamundaaa to merge support into mesa.

@Zamundaaa Zamundaaa marked this pull request as ready for review February 17, 2025 17:04
Dudemanguy
Dudemanguy reviewed Feb 17, 2025
View reviewed changes
Copy link
Member

@Dudemanguy Dudemanguy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some minor nits but should be good otherwise.

@Zamundaaa Zamundaaa force-pushed the work/final-color branch 2 times, most recently from d71038f to 1a568ea Compare February 17, 2025 18:17
@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 17, 2025 •
edited
Loading

Download the artifacts for this pull request:

Windows
macOS

Dudemanguy
Dudemanguy approved these changes Feb 17, 2025
View reviewed changes
Copy link
Member

@Dudemanguy Dudemanguy left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just shorten the commit message to wayland: update color management protocol to the final upstream version to make our lint happy but LGTM.

@Zamundaaa
Copy link
Contributor Author

done

@Dudemanguy
Copy link
Member

Dudemanguy commented Feb 17, 2025 •
edited
Loading

Unfortunately people using xx-color-management-v4 on git master will have some breakage until compositors catch up with newer releases, but hopefully it shouldn't be too long. Thanks for all the effort on the color stuff!

@Dudemanguy Dudemanguy merged commit 6bfbaf6 into mpv-player:master Feb 17, 2025
26 checks passed
@Headcrabed
Copy link

So icc-profile-auto config can also work now under linux wayland?

@llyyr
Copy link
Contributor

llyyr commented Feb 18, 2025

No, VOCTRL_GET_ICC_PROFILE would need to be implemented for wayland backend for that to work. Also I don't remember if the protocol provides a way for applications to retrieve icc profiles from compositor instead of just setting them

@emersion
Copy link
Contributor

The protocol does expose ICC profiles (but only Weston implements this feature).

@Headcrabed
Copy link

No, VOCTRL_GET_ICC_PROFILE would need to be implemented for wayland backend for that to work. Also I don't remember if the protocol provides a way for applications to retrieve icc profiles from compositor instead of just setting them

@Zamundaaa What do you think about this?

@Zamundaaa Zamundaaa deleted the work/final-color branch February 18, 2025 14:33
@Zamundaaa
Copy link
Contributor Author

Zamundaaa commented Feb 18, 2025 •
edited
Loading

As KWin doesn't implement the protocol ICC feature, I'm not personally interested in working on it. If someone else wants to do it, feel free to do it.

@Dudemanguy
Copy link
Member

So icc-profile-auto config can also work now under linux wayland?

Not yet but I have local branch and I'm working on it. I started the xx version here #15178 but it needs updating of course.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emersion emersion emersion left review comments

@kasper93 kasper93 kasper93 left review comments

@Dudemanguy Dudemanguy Dudemanguy approved these changes

@linkmauve linkmauve linkmauve left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@Zamundaaa @Dudemanguy @helixoid @returntoreality @Headcrabed @llyyr @emersion @kasper93 @linkmauve