options: add --secondary-sub-ass-override #13121
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dudemanguy
reviewed
Dec 16, 2023
|
Download the artifacts for this pull request: |
ed57f22 to
a592002
Compare
Dudemanguy
reviewed
Dec 16, 2023
a592002 to
31a31e3
Compare
|
After carefully reviewing #3022 again, I found that this pr still cannot close that issue, It also needs to implement custom options for secondary subtitle styles for internally converted text subtitles. Updated the commit information. |
sfan5
reviewed
Dec 17, 2023
Default: strip. preserve the old behavior
31a31e3 to
9f5e2bd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up to some discussion we had in #13073.
Regardless of whether we implement fully configurable for the secondary subs options in the future, the
ass_style_overrideneeds to be handled separately.