Fix model with no updated_at or deleted_at columns #104
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Laravel allows overriding the column name used for timestamps (by default
updated_at
/deleted_at
), or disabling timestamps completely by setting theUPDATED_AT
andDELETED_AT
constants tonull
(docs). With strict enough error reporting settings, whenever one of those columns is disabled (e.g. set tonull
), anErrorException
is thrown:versionable/src/Mpociot/Versionable/VersionableTrait.php
Line 273 in 9af7957
The pull request adds checks to ensure the column names for timestamps is valid/not null.