fix: Don't log info about the built extension when signing #577
Conversation
There was a problem hiding this comment.
I tested this out and it works great, thanks! I made a small request to fix some formatting.
Generally for patches like this we would need a test that ensures the run command is calling build() in a way that will execute the desired behavior. However, it's just a log statement in this case which is a bit harder to test so it's ok.
| @@ -69,7 +69,8 @@ export default function sign( | |||
| } | |||
|
|
|||
| let [buildResult, idFromSourceDir] = await Promise.all([ | |||
| build({sourceDir, artifactsDir: tmpDir.path()}, {manifestData}), | |||
| build({sourceDir, artifactsDir: tmpDir.path()}, {manifestData, | |||
| showReadyMessage: false}), | |||
There was a problem hiding this comment.
nitpicky request (sorry): when breaking a block into a new line, the break needs to be consistent. In this case the block is {manifestData, showReadyMessage: false}. You could make it break consistently in a couple different ways:
Here is an example of keeping all block elements on the same line:
build({sourceDir, artifactsDir: tmpDir.path()}, {
manifestData, showReadyMessage: false,
}),Here is an example of moving the entire block to a new line:
build({sourceDir, artifactsDir: tmpDir.path()},
{manifestData, showReadyMessage: false}),This type of consistency is hard to enforce with automatic lint rules so sorry about slowing you down to fix that. It's important to fix these kinds of things because otherwise other contributors may become distracted by the inconsistency when working on an unrelated feature.
There was a problem hiding this comment.
@kumar303 no problem, good to learn the something new
| @@ -78,7 +79,8 @@ export type PackageCreatorFn = | |||
| (params: PackageCreatorParams) => Promise<ExtensionBuildResult>; | |||
|
|
|||
| async function defaultPackageCreator( | |||
| {manifestData, sourceDir, fileFilter, artifactsDir}: PackageCreatorParams | |||
| {manifestData, sourceDir, fileFilter, artifactsDir, | |||
| showReadyMessage}: PackageCreatorParams | |||
There was a problem hiding this comment.
oops, I completely missed this one. This is also formatted inconsistently because the block is only partially broken into the next line. An easy fix would be:
async function defaultPackageCreator({
manifestData, sourceDir, fileFilter, artifactsDir, showReadyMessage
}: PackageCreatorParams): Promise<ExtensionBuildResult> {There was a problem hiding this comment.
no worries, let me know if you see anything else
Fix #181
Manually tested with example addon