chore(flow): Added flow suppress comments for expected flow typecheck…

… errors in tests
mozilla · Jul 13, 2020 · 5badee6 · 5badee6
1 parent 1ee5d06
commit 5badee6
Show file tree

Hide file tree

Showing 8 changed files with 24 additions and 17 deletions.
diff --git a/tests/unit/test-cmd/test.lint.js b/tests/unit/test-cmd/test.lint.js
@@ -25,14 +25,14 @@ describe('lint', () => {
       createLinter,
       runLinter,
       lint: (params = {}, options = {}) => {
-        return defaultLintCommand({
-          sourceDir: '/fake/source/dir',
-          ...params,
-        }, {
+        const mergedArgs = {sourceDir: '/fake/source/dir', ...params};
+        const mergedOpts = {
           createLinter,
           createFileFilter,
           ...options,
-        });
+        };
+        // $FlowIgnore: allow use of inexact object literal for testing purpose.
+        return defaultLintCommand(mergedArgs, mergedOpts);
       },
     };
   }

diff --git a/tests/unit/test-cmd/test.run.js b/tests/unit/test-cmd/test.run.js
@@ -51,10 +51,9 @@ function prepareRun(fakeInstallResult) {
   return {
     argv,
     options,
-    run: (customArgv = {}, customOpt = {}) => run(
-      {...argv, ...customArgv},
-      {...options, ...customOpt}
-    ),
+    run: (customArgv = {}, customOpt = {}) =>
+      // $FlowIgnore: allow use of inexact object literal for testing purpose.
+      run({...argv, ...customArgv}, {...options, ...customOpt}),
   };
 }
 
@@ -129,7 +128,9 @@ describe('run', () => {
       firefoxBinary: runOptions.firefox,
       customPrefs: runOptions.pref,
     };
+    // $FlowIgnore: Allow deleting properties for testing purpose.
     delete expectedRunnerParams.firefox;
+    // $FlowIgnore: Allow deleting properties for testing purpose.
     delete expectedRunnerParams.pref;
 
     assert.deepEqual({

diff --git a/tests/unit/test-extension-runners/test.extension-runners.js b/tests/unit/test-extension-runners/test.extension-runners.js
@@ -306,6 +306,7 @@ describe('util/extension-runners', () => {
       return {
         config,
         createWatcher: (customConfig = {}) => {
+          // $FlowIgnore: allow use of inexact object literal for testing purpose.
           return defaultWatcherCreator({...config, ...customConfig});
         },
       };
@@ -403,9 +404,10 @@ describe('util/extension-runners', () => {
         watcher,
         extensionRunner,
         reloadStrategy: async (argOverride = {}, optOverride = {}) => {
-          return defaultReloadStrategy(
-            {...args, ...argOverride},
-            {...options, ...optOverride});
+          const mergedArgs = {...args, ...argOverride};
+          const mergedOpts = {...options, ...optOverride};
+          // $FlowIgnore: allow use of inexact object literal for testing purpose.
+          return defaultReloadStrategy(mergedArgs, mergedOpts);
         },
       };
     }

diff --git a/tests/unit/test-extension-runners/test.firefox-android.js b/tests/unit/test-extension-runners/test.firefox-android.js
@@ -95,6 +95,7 @@ function prepareExtensionRunnerParams({
       return Promise.resolve(remoteFirefox);
     }),
     desktopNotifications: sinon.spy(() => {}),
+    // $FlowIgnore: Allow to mock stdin with an EventEmitter for testing purpose.
     stdin: new EventEmitter(),
     ...(params || {}),
   };
@@ -930,11 +931,9 @@ describe('util/extension-runners/firefox-android', () => {
       ];
 
       for (const testCase of optionsWarningTestCases) {
-        // $FlowIgnore: allow overriden params for testing purpose.
-        new FirefoxAndroidExtensionRunner({ // eslint-disable-line no-new
-          ...params,
-          ...(testCase.params),
-        });
+        const runnerOptions = {...params, ...(testCase.params)};
+        // $FlowIgnore: allow use of inexact object literal for testing purpose.
+        new FirefoxAndroidExtensionRunner(runnerOptions); // eslint-disable-line no-new
 
         assert.match(
           consoleStream.capturedMessages[0],

diff --git a/tests/unit/test-firefox/test.firefox.js b/tests/unit/test-firefox/test.firefox.js
@@ -103,6 +103,7 @@ describe('firefox', () => {
         ...args
       }: RunFirefoxOptions = {},
     ) {
+      // $FlowIgnore: allow use of inexact object literal for testing purpose.
       return firefox.run(profile, {
         fxRunner: createFakeFxRunner(),
         findRemotePort: () => Promise.resolve(6000),

diff --git a/tests/unit/test-firefox/test.remote.js b/tests/unit/test-firefox/test.remote.js
@@ -34,6 +34,7 @@ describe('firefox.remote', () => {
           sinon.spy(() => Promise.resolve(fakeFirefoxClient())),
         ...options,
       };
+      // $FlowIgnore: allow use of inexact object literal for testing purpose.
       const connect = defaultConnector(port, options);
       return {options, connect};
     }
@@ -398,6 +399,7 @@ describe('firefox.remote', () => {
   describe('connectWithMaxRetries', () => {
 
     function firefoxClient(opt = {}, deps) {
+      // $FlowIgnore: allow use of inexact object literal for testing purpose.
       return connectWithMaxRetries({
         maxRetries: 0, retryInterval: 1, port: 6005, ...opt,
       }, deps);

diff --git a/tests/unit/test-util/test.file-filter.js b/tests/unit/test-util/test.file-filter.js
@@ -7,6 +7,7 @@ import {FileFilter, isSubPath} from '../../../src/util/file-filter';
 describe('util/file-filter', () => {
 
   const newFileFilter = (params = {}) => {
+    // $FlowIgnore: allow use of inexact object literal for testing purpose.
     return new FileFilter({
       sourceDir: '.',
       ...params,

diff --git a/tests/unit/test.config.js b/tests/unit/test.config.js
@@ -955,6 +955,7 @@ describe('config', () => {
 
   describe('discoverConfigFiles', () => {
     function _discoverConfigFiles(params = {}) {
+      // $FlowIgnore: allow use of inexact object literal for testing purpose.
       return discoverConfigFiles({
         // By default, do not look in the real home directory.
         getHomeDir: () => '/not-a-directory',