Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove ./ from paths #1545

Merged
merged 3 commits into from
May 17, 2023
Merged

Remove ./ from paths #1545

merged 3 commits into from
May 17, 2023

Conversation

heinrich5991
Copy link
Contributor

Make CODE_OF_CONDUCT.md non-executable and remove unneeded ./ from paths. ./ doesn't do anything.

@heinrich5991 heinrich5991 requested a review from a team as a code owner May 17, 2023 07:37
@heinrich5991 heinrich5991 requested review from bendk and removed request for a team May 17, 2023 07:37
@mhammond
Copy link
Member

I like the first and last commits, but don't understand what harm the "./" is doing?

@heinrich5991
Copy link
Contributor Author

I like the first and last commits, but don't understand what harm the "./" is doing?

No harm, just superfluous. What value does "./" add? I can drop the commit if wanted.

@jplatte
Copy link
Collaborator

jplatte commented May 17, 2023

I also prefer it without ./, I would say it's just because less punctuation = easier to read.

mhammond
mhammond approved these changes May 17, 2023
View reviewed changes
Copy link
Member

@mhammond mhammond left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, I'm sold :)

@mhammond mhammond merged commit 517112f into mozilla:main May 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mhammond mhammond mhammond approved these changes

@bendk bendk Awaiting requested review from bendk bendk is a code owner automatically assigned from mozilla/uniffi-devs

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@heinrich5991 @mhammond @jplatte