Fix #507 : Rename Get Permalink to Get shortlink in measurements dashboard #512
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
georgf
approved these changes
Mar 28, 2018
| @@ -56,7 +56,7 @@ A local webserver is really helpful for running a version of the site on the sam | |||
| npm install http-server -g | |||
| # now visit localhost:8080 in your browser to see the page | |||
|
|
|||
| Permalink buttons (in the top right hand corner of the main dashboards) will not work when running the site on local servers. This is because they are shortened with bit.ly, which doesn't allow local links. | |||
| Shortlink buttons (in the top right hand corner of the main dashboards) will not work when running the site on local servers. This is because they are shortened with bit.ly, which doesn't allow local links. | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the measurements dashboard, the "Get permalink" button actually gets us a "shortlink". We should rename it to
Get Shortlinkto avoid misunderstandings.Three files have been affected
dist.html,evo.htmlandREADME.mdfor better user experience and documentation.@georgf Please review. Thanks!