Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove usage of kernel32-sys crate #456

Merged
merged 1 commit into from
Jun 24, 2019
Merged

Remove usage of kernel32-sys crate #456

merged 1 commit into from
Jun 24, 2019

Conversation

tesuji
Copy link
Contributor

@tesuji tesuji commented Jun 21, 2019

Closes #439

@tesuji tesuji force-pushed the unused-kernle32 branch 2 times, most recently from 34f527c to cdfb354 Compare June 21, 2019 18:40
@tesuji tesuji mentioned this pull request Jun 22, 2019
Closed
@froydnj
Copy link
Contributor

froydnj commented Jun 24, 2019

This looks fine to me; could you please squash your commits into a single one, @lzutao ?

@tesuji tesuji force-pushed the unused-kernle32 branch from 0294ebf to 48982f6 Compare June 24, 2019 16:32
@tesuji
Copy link
Contributor Author

tesuji commented Jun 24, 2019

Done.

@tesuji
Copy link
Contributor Author

tesuji commented Jun 24, 2019

@chmanchester Could you leave a review for this PR?

@froydnj froydnj merged commit 5855673 into mozilla:master Jun 24, 2019
@froydnj
Copy link
Contributor

froydnj commented Jun 24, 2019

The CI failure is just a failure to upload, which seems harmless, and worked on a retrigger. Thanks!

@tesuji tesuji deleted the unused-kernle32 branch June 24, 2019 21:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove usage of kernel32-sys crate
2 participants
@tesuji @froydnj