Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update most dependencies #286

Merged
merged 21 commits into from
Aug 31, 2018
Merged

Update most dependencies #286

merged 21 commits into from
Aug 31, 2018

Conversation

Marwes
Copy link
Contributor

@Marwes Marwes commented Aug 28, 2018

Just went through and updated most dependencies of sccache, mainly small cosmetic changes but I also used reqwest instead of hyper::Client in more places to be able to remove the explicit hyper-tls usage.

cargo outdated -R

Name     Project  Compat  Latest  Kind    Platform
----     -------  ------  ------  ----    --------
bincode  0.9.2    ---     1.0.1   Normal  ---
hyper    0.11.27  ---     0.12.8  Normal  ---

Avoided updating bincode since there maybe be versioning issues(?).

hyper-0.11 is also needed reqwest (no version has been release with hyper-0.12 yet) so I left it alone.

@luser
Copy link
Contributor

luser commented Aug 28, 2018

Thanks for the patch! This seems to be broken on Windows though, all the AppVeyor builds are busted:

error[E0432]: unresolved import `url`
  --> src\azure\blobstore.rs:25:5
   |
25 | use url::Url;
   |     ^^^ Did you mean `rouille::url`?
warning: unused import: `std::str::FromStr`

Note that Windows CI builds use --features="all-windows" which is "everything but gcs":

all-windows = ["redis", "s3", "memcached", "azure"]

@Marwes
Copy link
Contributor Author

Marwes commented Aug 28, 2018

Had to add the url feature for azure. Also updated winapi to 0.3.

@luser
Copy link
Contributor

luser commented Aug 30, 2018

Avoided updating bincode since there maybe be versioning issues(?).

I don't think this is a problem. sccache only uses bincode for communication between the client and server on the same machine, so they should always be the same version.

@Marwes
Copy link
Contributor Author

Marwes commented Aug 30, 2018

👍 Going through the rebase atm

@luser
Copy link
Contributor

luser commented Aug 30, 2018

👍 Going through the rebase atm

Great, thanks! I started looking at this but it was sort of a PITA.

@Marwes
Copy link
Contributor Author

Marwes commented Aug 30, 2018

Rebased and updated rand and bincode as well

@luser luser merged commit 8cae3d6 into mozilla:master Aug 31, 2018
@luser
Copy link
Contributor

luser commented Aug 31, 2018

Thanks again! I should probably set up dependabot now that you've done most of the hard work. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants