Skip to content
This repository has been archived by the owner on Nov 11, 2019. It is now read-only.

staticanalysis/bot: Avoid using bad values for HarborMaster target #2040

Merged
merged 1 commit into from
Apr 15, 2019
Merged

staticanalysis/bot: Avoid using bad values for HarborMaster target #2040

merged 1 commit into from
Apr 15, 2019

Conversation

La0
Copy link
Contributor

@La0 La0 commented Apr 12, 2019

No description provided.

@La0 La0 requested a review from marco-c April 12, 2019 14:53
@La0 La0 self-assigned this Apr 12, 2019
marco-c
marco-c approved these changes Apr 12, 2019
View reviewed changes
Copy link
Collaborator

@marco-c marco-c left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When could the value be wrong? Should we log it?

@La0
Copy link
Contributor Author

La0 commented Apr 15, 2019

Pulelistener is setting the env variable to None in Python, which is then converted to null by json-e, which is then loaded as "null" back in Python in static analysis bot... So I get a string instead of a null, and the test fails...

@La0
Copy link
Contributor Author

La0 commented Apr 15, 2019

I pushed this fix last Friday on prod (i know...) it fixed all the failing analysis.

@La0 La0 merged commit 43d4434 into mozilla:master Apr 15, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@marco-c marco-c marco-c approved these changes

Assignees

@La0 La0

Labels
app:staticanalysis/bot kind:bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@La0 @marco-c