This repository has been archived by the owner on Nov 11, 2019. It is now read-only.
Load diff_phid from try task as early as possible #1960
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marco-c
reviewed
Mar 18, 2019
| @@ -223,7 +232,7 @@ def namespaces(self): | |||
| ] | |||
|
|
|||
| def __repr__(self): | |||
| return self.diff_phid | |||
| return self.diff_phid or 'unknown' | |||
There was a problem hiding this comment.
Shouldn't diff_phid always have a value?
There was a problem hiding this comment.
Yes, i did that before moving the logic in the constructor
marco-c
approved these changes
Mar 18, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was initially made in #1953 , and runs on testing.
It's needed to load the Phabricator revision from a task triggered by pulse in the try workflow