This repository has been archived by the owner on Nov 11, 2019. It is now read-only.
Use bugzilla instead of release-services for phabricator issues #1882
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good, the expected messages in the test (https://github.com/mozilla/release-services/blob/master/src/staticanalysis/bot/tests/test_reporter_phabricator.py) need to be updated too. |
marco-c
reviewed
Feb 14, 2019
| @@ -12,7 +12,7 @@ | |||
| from static_analysis_bot.report.base import Reporter | |||
| from static_analysis_bot.revisions import PhabricatorRevision | |||
|
|
|||
| BUG_REPORT_URL = 'https://github.com/mozilla/release-services/issues/new?title=Problem%20with%20an%20automated%20review:%20SUMMARY&labels=app:staticanalysis/bot&body=**Phabricator%20URL:**%20https://phabricator.services.mozilla.com/D%E2%80%A6%0A%0A**Problem:**%20%E2%80%A6' # noqa | |||
| BUG_REPORT_URL = 'https://bugzilla.mozilla.org/enter_bug.cgi?product=Firefox+Build+System&component=Source+Code+Analysis&short_desc=[Automated+review]+UPDATE&comment=**Phabricator URL:** https://phabricator.services.mozilla.com/...&format=__default__' | |||
There was a problem hiding this comment.
You'll need the #noqa at the end to silence flake8
marco-c
approved these changes
Feb 14, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In many cases, we have to do something in-tree. To me, it makes more sense to do that in bugzilla
and keep release services for infra work