This repository has been archived by the owner on Nov 11, 2019. It is now read-only.
shipit/api: action hook support #1782
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds support for handling both action kinds (task and hook). The unusual part was that we cannot pre-set the action hook generated taskId, we have to update it dynamically (in the DB and the input).
|
@escapewindow can you take a look at this |
escapewindow
approved these changes
Jan 8, 2019
| queue = get_service('queue') | ||
| queue.createTask(phase.task_id, phase.rendered) | ||
| task_or_hook = phase.task_json | ||
| if 'hook_payload' in task_or_hook: |
There was a problem hiding this comment.
I'm guessing this is correct. I don't know what's in task_or_hook or where it comes from.
There was a problem hiding this comment.
Yeah, this is our internal structure.
| # some parameters contain a lot of entries, so we hit the payload | ||
| # size limit. We don't use this parameter in any case, safe to | ||
| # remove | ||
| for long_param in ('existing_tasks', 'release_history', 'release_partner_config'): |
There was a problem hiding this comment.
Nice, is this fixed now?
There was a problem hiding this comment.
Just moved it to make the API file less crowded. :)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support for handling both action kinds (task and hook). The
unusual part was that we cannot pre-set the action hook generated
taskId, we have to update it dynamically (in the DB and the input).
I tested it in staging only using Fennec (Firefox partials won't cooperate). Example generated action tasks for promote_fennec and ship_fennec. The values of
previous_graph_idslook sane to me.