This repository has been archived by the owner on Nov 11, 2019. It is now read-only.
bugbug/*: Update dependencies #1751
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
743dd55 to
0767ba8
Compare
marco-c
commented
Dec 18, 2018
| }; | ||
| doCheck = commonDoCheck; | ||
| checkPhase = ""; | ||
| installCheckPhase = ""; | ||
| buildInputs = commonBuildInputs ++ [ ]; | ||
| propagatedBuildInputs = [ | ||
| self."en-core-web-sm" |
There was a problem hiding this comment.
Even though I have this dependency in bugbug now, I still need to manually add https://github.com/explosion/spacy-models/releases/download/en_core_web_sm-2.0.0/en_core_web_sm-2.0.0.tar.gz#egg=en-core-web-sm in requirements.txt. pypi2nix fails otherwise when updating depedencies (tries hitting https://pypi.org/ even though the package is not uploaded to pypi).
CC @garbas
There was a problem hiding this comment.
not sure what you are asking here. for me it looks like en-core-web-sm is a dependency of spacy since you need to create a symlink there.
0767ba8 to
dcb1e61
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.