57 add warnings #91
Merged
57 add warnings #91
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mozilla#57 I tried to make `JSON.stringify(this.visualization.options.columnMapping)` a variable to avoid repeating it, but if I make it a `let` the linter throws an error and if I make it a `const` then it doesn’t change with the UI and the logic doesn’t work. :(
spasovski
reviewed
Jul 7, 2017
| @@ -33,10 +33,18 @@ <h4 class="modal-title">Visualization Editor</h4> | |||
| <div class="col-md-7" style="border: 1px solid #eee"> | |||
| <visualization-renderer visualization="$ctrl.visualization" query-result="$ctrl.queryResult"></visualization-renderer> | |||
| </div> | |||
| <div class="col-md-7"> | |||
| <div class="bg-warning" ng-if="$ctrl.visualization.options.series.stacking == null && $ctrl.has3plusColumnsFunction()" style="padding:2%;" ng-bind-html="$ctrl.warning_three_column_stacking"> | |||
There was a problem hiding this comment.
Let's not do inline styles please. Also 2% may not work too well maybe something as a 'px' value.
There was a problem hiding this comment.
@spasovski What's the right file to add a CSS class in?
There was a problem hiding this comment.
Arik prefers creating a CSS file for each component and then requiring it since webpack will do the rest. Not a personal fan of importing CSS this way but we should stick to it for consistency. See https://github.com/getredash/redash/pull/1569/files#diff-855c4fc3efcfee2ac69a13e2f2810ecbR3 for reference.
spasovski
reviewed
Jul 7, 2017
| @@ -19,6 +19,9 @@ const EditVisualizationDialog = { | |||
| this.visualization = copy(this.originalVisualization); | |||
| this.visTypes = Visualization.visualizationTypes; | |||
|
|
|||
| this.warning_three_column_groupby = '<b>You have more than 2 columns in your result set.</b> To ensure the chart is accurate, please do one of the following: <ul> <li>Change the SQL query to give 2 result columns. You can CONCAT() columns together if you wish.</li> <LI>Select column(s) to group by.</LI> </ul>'; | |||
| this.warning_three_column_stacking = '<B>You have more than 2 columns in your result set.</b> You may wish to make the Stacking option equal to `Enabled` or `Percent`.'; | |||
There was a problem hiding this comment.
Let's do lowercase HTML tags for consistency.
|
Looks great thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#57
I tried to make
JSON.stringify(this.visualization.options.columnMapping)a variableto avoid repeating it, but if I make it a
letthe linter throws anerror and if I make it a
constthen it doesn’t change with the UI andthe logic doesn’t work. :(