Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The annotation layer dimensions must be set before adding some elements (follow-up of #15770) #15820

Merged
merged 1 commit into from
Dec 13, 2022
Merged

The annotation layer dimensions must be set before adding some elements (follow-up of #15770) #15820

merged 1 commit into from
Dec 13, 2022

Conversation

calixteman
Copy link
Contributor

In order to move the annotations in the DOM to have something which corresponds to the visual order, we need to have their dimensions/positions which means that the parent must have some dimensions.

@calixteman
The annotation layer dimensions must be set before adding some elemen…
1a39768 
…ts (follow-up of mozilla#15770)

In order to move the annotations in the DOM to have something which corresponds
to the visual order, we need to have their dimensions/positions which means that
the parent must have some dimensions.
Snuffleupagus
Snuffleupagus approved these changes Dec 13, 2022
View reviewed changes
Copy link
Collaborator

@Snuffleupagus Snuffleupagus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r=me, with passing tests; thank you!

@calixteman
Copy link
Contributor Author

/botio integrationtest

@pdfjsbot
Copy link

From: Bot.io (Linux m4)

Received

Command cmd_integrationtest from @calixteman received. Current queue size: 0

Live output at: http://54.241.84.105:8877/4919b7feaf18d54/output.txt

@pdfjsbot
Copy link

From: Bot.io (Windows)

Received

Command cmd_integrationtest from @calixteman received. Current queue size: 0

Live output at: http://54.193.163.58:8877/7481aae540d24a1/output.txt

@pdfjsbot
Copy link

From: Bot.io (Linux m4)

Success

Full output at http://54.241.84.105:8877/4919b7feaf18d54/output.txt

Total script time: 4.71 mins

  • Integration Tests: Passed

@pdfjsbot
Copy link

From: Bot.io (Windows)

Failed

Full output at http://54.193.163.58:8877/7481aae540d24a1/output.txt

Total script time: 14.79 mins

  • Integration Tests: FAILED

@calixteman
Copy link
Contributor Author

/botio unittest

@pdfjsbot
Copy link

From: Bot.io (Linux m4)

Received

Command cmd_unittest from @calixteman received. Current queue size: 0

Live output at: http://54.241.84.105:8877/978130805308b0b/output.txt

@pdfjsbot
Copy link

From: Bot.io (Windows)

Received

Command cmd_unittest from @calixteman received. Current queue size: 0

Live output at: http://54.193.163.58:8877/0f95f0a150240cd/output.txt

@pdfjsbot
Copy link

From: Bot.io (Linux m4)

Success

Full output at http://54.241.84.105:8877/978130805308b0b/output.txt

Total script time: 2.42 mins

  • Unit Tests: Passed

@pdfjsbot
Copy link

From: Bot.io (Windows)

Success

Full output at http://54.193.163.58:8877/0f95f0a150240cd/output.txt

Total script time: 8.04 mins

  • Unit Tests: Passed

@calixteman calixteman merged commit 64786b4 into mozilla:master Dec 13, 2022
@calixteman calixteman deleted the fix_visual_order branch December 13, 2022 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Snuffleupagus Snuffleupagus Snuffleupagus approved these changes

Assignees
No one assigned
Labels
accessibility annotations
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@calixteman @pdfjsbot @Snuffleupagus