Add an empty entry in combo list when nothing is selected (bug 1773680)

[calixteman]

• it aims to fix https://bugzilla.mozilla.org/show_bug.cgi?id=1773680
• the empty is removed once something is selected.

[Snuffleupagus]

r=me, with one more suggestion and passing tests; thank you!

[calixteman]

/botio test

[pdfjsbot]

From: Bot.io (Linux m4)

---

Received

Command cmd_test from @calixteman received. Current queue size: 0

Live output at: http://54.241.84.105:8877/8d14a5e52b21352/output.txt

[pdfjsbot]

From: Bot.io (Windows)

---

Received

Command cmd_test from @calixteman received. Current queue size: 0

Live output at: http://54.193.163.58:8877/3ab8dc8b8f6d7ca/output.txt

[pdfjsbot]

From: Bot.io (Linux m4)

---

Failed

Full output at http://54.241.84.105:8877/8d14a5e52b21352/output.txt

Total script time: 26.02 mins

• Font tests: Passed
• Unit tests: FAILED
• Integration Tests: Passed
• Regression tests: FAILED

  errors: 2
  different ref/snapshot: 42

Image differences available at: http://54.241.84.105:8877/8d14a5e52b21352/reftest-analyzer.html#web=eq.log

[pdfjsbot]

From: Bot.io (Windows)

---

Failed

Full output at http://54.193.163.58:8877/3ab8dc8b8f6d7ca/output.txt

Total script time: 28.20 mins

• Font tests: Passed
• Unit tests: Passed
• Integration Tests: FAILED
• Regression tests: FAILED

  errors: 1
  different ref/snapshot: 5

Image differences available at: http://54.193.163.58:8877/3ab8dc8b8f6d7ca/reftest-analyzer.html#web=eq.log

[Snuffleupagus]

According to the test results and logs, this document is a duplicate of issue12233.pdf and shouldn't be added.

Hence the manifest-entry below should reference the existing file instead, assuming that we even need to add a new test here (since the existing test-cases may already cover this).

[calixteman]

The "regression" in 160F-2019.pdf doesn't make sense. The patch just changed some code in ChoiceWidget and the hello world is in a TextWidget.
The one in annotation-choice-widget-forms.pdf is a bug fix: I opened it in Acrobat and the combo is empty and I rg for the md5 in the wrong directory so my test is useless.

[calixteman]

@Snuffleupagus, the regression in 160F-2019 is very likely unrelated to this patch, or maybe I overlooked something, are you still ok to merge it ?

[Snuffleupagus]

The "regression" in 160F-2019.pdf doesn't make sense. The patch just changed some code in ChoiceWidget and the hello world is in a TextWidget.

Agreed, I also don't understand how that could've happened.

the regression in 160F-2019 is very likely unrelated to this patch, or maybe I overlooked something, are you still ok to merge it ?

Assuming it's even a regression, since comparing with Adobe Reader I'm not sure...

---

While I'd suggest that it makes sense to try and understand what changed and importantly why here, I suppose that this PR can still land in the meantime :-)

[calixteman]

It's very likely my fault:
5d88233#diff-a7e409abd3d3209d32d3adc8457c5e23feb4c06113a2e065b0c6a9322a3a3369R744

[calixteman]

/botio makeref

[pdfjsbot]

From: Bot.io (Linux m4)

---

Received

Command cmd_makeref from @calixteman received. Current queue size: 0

Live output at: http://54.241.84.105:8877/6ea1e23602fe397/output.txt

[pdfjsbot]

From: Bot.io (Windows)

---

Received

Command cmd_makeref from @calixteman received. Current queue size: 1

Live output at: http://54.193.163.58:8877/f70f09fc715dc69/output.txt

[calixteman]

The border is white so the reftest is now correct. Probably at some point the stroke color was black and because of wrong g we weren't using the white. So thanks to the patch for the ink stuff, it's now fixed.
I'm sorry about that.

[pdfjsbot]

From: Bot.io (Linux m4)

---

Success

Full output at http://54.241.84.105:8877/6ea1e23602fe397/output.txt

Total script time: 23.39 mins

• Lint: Passed
• Make references: Passed
• Check references: Passed

[pdfjsbot]

From: Bot.io (Windows)

---

Success

Full output at http://54.193.163.58:8877/f70f09fc715dc69/output.txt

Total script time: 21.63 mins

• Lint: Passed
• Make references: Passed
• Check references: Passed

[Snuffleupagus]

The border is white so the reftest is now correct. Probably at some point the stroke color was black and because of wrong g we weren't using the white. So thanks to the patch for the ink stuff, it's now fixed.

Thanks for figuring this out, since it confirms that the current state is indeed correct now!
(We both missed running the full test-suite in PR #15006 apparently...)

I'm sorry about that.

Don't apologize for fixing an old bug :-)