Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Render PopupAnnotations even if they have missing or empty /Rect-entries (issue 15012, PR 14439 follow-up) #15013

Merged
merged 2 commits into from
Jun 9, 2022
Merged

Render PopupAnnotations even if they have missing or empty /Rect-entries (issue 15012, PR 14439 follow-up) #15013

merged 2 commits into from
Jun 9, 2022

Conversation

Snuffleupagus
Copy link
Collaborator

@Snuffleupagus Snuffleupagus commented Jun 9, 2022 •
edited
Loading

This only applies to corrupt PDF documents, where Annotations are missing the required /Rect-entry. Rendering PopupAnnotations unconditionally shouldn't be a problem, since we're not using a BaseSVGFactory-instance in that case.

@Snuffleupagus Snuffleupagus linked an issue Jun 9, 2022 that may be closed by this pull request
Annotation popup is not displayed #15012
Closed
@Snuffleupagus Snuffleupagus changed the title Check the *correct* /Rect-entry when checking for empty PopupAnnotations (issue 15012, PR 14438 follow-up) Use the *correct* /Rect-entry when checking for empty PopupAnnotations (issue 15012, PR 14438 follow-up) Jun 9, 2022
@Snuffleupagus Snuffleupagus changed the title Use the *correct* /Rect-entry when checking for empty PopupAnnotations (issue 15012, PR 14438 follow-up) Use the *correct* /Rect-entry when checking for empty PopupAnnotations (issue 15012, PR 14439 follow-up) Jun 9, 2022
@Snuffleupagus Snuffleupagus force-pushed the issue-15012 branch 3 times, most recently from 0d177bf to 35c0b99 Compare June 9, 2022 13:07
@Snuffleupagus Snuffleupagus changed the title Use the *correct* /Rect-entry when checking for empty PopupAnnotations (issue 15012, PR 14439 follow-up) Render PopupAnnotations even if they have missing or empty /Rect-entries (issue 15012, PR 14439 follow-up) Jun 9, 2022
@Snuffleupagus
Render PopupAnnotations even if they have missing or empty /Rect-entr…
3d244cb 
…ies (issue 15012, PR 14439 follow-up)

This only applies to *corrupt* PDF documents, where Annotations are missing the required /Rect-entry. Rendering PopupAnnotations unconditionally shouldn't be a problem, since we're not using a `BaseSVGFactory`-instance in that case.
@Snuffleupagus
Force-install npm packages to try and fix the repeated GitHub Action …
6371a76 
…failures
@Snuffleupagus
Copy link
Collaborator Author

/botio test

@pdfjsbot
Copy link

pdfjsbot commented Jun 9, 2022

From: Bot.io (Linux m4)

Received

Command cmd_test from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.241.84.105:8877/8ab7caf9a4bbd17/output.txt

@pdfjsbot
Copy link

pdfjsbot commented Jun 9, 2022

From: Bot.io (Windows)

Received

Command cmd_test from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.193.163.58:8877/5458aabe4c549f7/output.txt

@pdfjsbot
Copy link

pdfjsbot commented Jun 9, 2022

From: Bot.io (Linux m4)

Failed

Full output at http://54.241.84.105:8877/8ab7caf9a4bbd17/output.txt

Total script time: 26.04 mins

  • Font tests: Passed
  • Unit tests: FAILED
  • Integration Tests: Passed
  • Regression tests: FAILED
  different ref/snapshot: 24
  different first/second rendering: 1

Image differences available at: http://54.241.84.105:8877/8ab7caf9a4bbd17/reftest-analyzer.html#web=eq.log

@pdfjsbot
Copy link

pdfjsbot commented Jun 9, 2022

From: Bot.io (Windows)

Failed

Full output at http://54.193.163.58:8877/5458aabe4c549f7/output.txt

Total script time: 27.91 mins

  • Font tests: Passed
  • Unit tests: Passed
  • Integration Tests: Passed
  • Regression tests: FAILED
  different ref/snapshot: 1

Image differences available at: http://54.193.163.58:8877/5458aabe4c549f7/reftest-analyzer.html#web=eq.log

@Snuffleupagus Snuffleupagus marked this pull request as ready for review June 9, 2022 13:39
calixteman
calixteman approved these changes Jun 9, 2022
View reviewed changes
Copy link
Contributor

@calixteman calixteman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you.

@Snuffleupagus Snuffleupagus merged commit 1eaef66 into mozilla:master Jun 9, 2022
@Snuffleupagus
Copy link
Collaborator Author

/botio makeref

@pdfjsbot
Copy link

pdfjsbot commented Jun 9, 2022

From: Bot.io (Linux m4)

Received

Command cmd_makeref from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.241.84.105:8877/eaa0c92bb3b7d47/output.txt

@pdfjsbot
Copy link

pdfjsbot commented Jun 9, 2022

From: Bot.io (Windows)

Received

Command cmd_makeref from @Snuffleupagus received. Current queue size: 1

Live output at: http://54.193.163.58:8877/31cd0e27c1f16d6/output.txt

@pdfjsbot
Copy link

pdfjsbot commented Jun 9, 2022

From: Bot.io (Linux m4)

Success

Full output at http://54.241.84.105:8877/eaa0c92bb3b7d47/output.txt

Total script time: 22.66 mins

  • Lint: Passed
  • Make references: Passed
  • Check references: Passed

@pdfjsbot
Copy link

pdfjsbot commented Jun 9, 2022

From: Bot.io (Windows)

Success

Full output at http://54.193.163.58:8877/31cd0e27c1f16d6/output.txt

Total script time: 22.24 mins

  • Lint: Passed
  • Make references: Passed
  • Check references: Passed

@Snuffleupagus Snuffleupagus deleted the issue-15012 branch June 9, 2022 15:27
@ZeroXClem ZeroXClem mentioned this pull request Aug 12, 2024
Closed
@earthywh earthywh mentioned this pull request Sep 24, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@calixteman calixteman calixteman approved these changes

Assignees
No one assigned
Labels
annotations
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Annotation popup is not displayed
3 participants
@Snuffleupagus @pdfjsbot @calixteman