Remove redundant class names from the button DOM-elements #14854
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Note how in the `viewer.html` file we're specifying class names for most buttons, despite that not really being necessary. First of all, in many cases those class names are *identical* to the element-ids. Secondly, looking through the CSS rules they are only ever used when specifying button icons. All-in-all, we should be able to simplify the HTML-code and use the element-ids in the CSS rules instead. Obviously ids have a higher CSS specificity than classes, but given how the old classes were being used that shouldn't be a problem here. Also, the patch generalizes the styling for buttons (e.g. `viewBookmark`) that are *actually* link-elements. Finally, while slightly unrelated, this patch also removes a little bit of duplication when specifying the border for `toolbarField`s.
96366e1 to
776fd3a
Compare
From: Bot.io (Linux m4)ReceivedCommand cmd_preview from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.241.84.105:8877/73cec2112460dd9/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.241.84.105:8877/73cec2112460dd9/output.txt Total script time: 2.53 mins Published |
Currently we're using *both* ids and classes when specifying the button icons, which seems completely unnecessary and only serves to bloat the CSS code. In general you always need to be careful about CSS specificity, but in these cases that should not actually be a problem. Also, while not a button, this patch makes a similar simplification for the `pageNumber`-input.
776fd3a to
1e24fe9
Compare
timvandermeij
approved these changes
Apr 30, 2022
|
Looks good to me! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.