-
Notifications
You must be signed in to change notification settings - Fork 10.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for the /Catalog Base-URI when resolving URLs (issue 14802) #14803
Conversation
3d6f651
to
d6b1876
Compare
As far as I can tell, this is actually the very first time that we've seen a PDF document with a Base-URI specified in the /Catalog; please refer to the specification: https://web.archive.org/web/20220309040754if_/https://www.adobe.com/content/dam/acom/en/devnet/pdf/pdfs/PDF32000_2008.pdf#G11.2097122 To simplify the overall implementation, this new parameter is accessed via the existing `BasePdfManager.docBaseUrl`-getter and will thus override any user-specified `docBaseUrl` API-parameter.
d6b1876
to
5bc7339
Compare
/botio test |
From: Bot.io (Linux m4)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.241.84.105:8877/6a73d478752717b/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.193.163.58:8877/bffa2609ede9a54/output.txt |
From: Bot.io (Linux m4)FailedFull output at http://54.241.84.105:8877/6a73d478752717b/output.txt Total script time: 23.76 mins
Image differences available at: http://54.241.84.105:8877/6a73d478752717b/reftest-analyzer.html#web=eq.log |
From: Bot.io (Windows)FailedFull output at http://54.193.163.58:8877/bffa2609ede9a54/output.txt Total script time: 24.29 mins
Image differences available at: http://54.193.163.58:8877/bffa2609ede9a54/reftest-analyzer.html#web=eq.log |
/botio-linux preview |
From: Bot.io (Linux m4)ReceivedCommand cmd_preview from @timvandermeij received. Current queue size: 0 Live output at: http://54.241.84.105:8877/ac74827d2066351/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.241.84.105:8877/ac74827d2066351/output.txt Total script time: 2.82 mins Published |
Thank you for implementing this, and good to see a /botio makeref |
From: Bot.io (Linux m4)ReceivedCommand cmd_makeref from @timvandermeij received. Current queue size: 0 Live output at: http://54.241.84.105:8877/6ba04f7718951e6/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_makeref from @timvandermeij received. Current queue size: 1 Live output at: http://54.193.163.58:8877/3c6399d568e8563/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.241.84.105:8877/6ba04f7718951e6/output.txt Total script time: 22.36 mins
|
From: Bot.io (Windows)SuccessFull output at http://54.193.163.58:8877/3c6399d568e8563/output.txt Total script time: 20.93 mins
|
As far as I can tell, this is actually the very first time that we've seen a PDF document with a Base-URI specified in the /Catalog; please refer to the specification:
https://web.archive.org/web/20220309040754if_/https://www.adobe.com/content/dam/acom/en/devnet/pdf/pdfs/PDF32000_2008.pdf#G11.2097122
To simplify the overall implementation, this new parameter is accessed via the existing
BasePdfManager.docBaseUrl
-getter and will thus override any user-specifieddocBaseUrl
API-parameter.