Slightly simplify the PDFFindController._extractText method, and convert all "private" methods into proper ones
#14689
Conversation
Currently we're resolving the Promises in the `_extractTextPromises` Array with the page-index, despite that not really being necessary since the Promises in the Array are explicitly inserted in the correct order. Furthermore, we can replace the standard `for`-loop with a `for...of`-loop which results in ever so slightly more compact code.
Given that none of these methods are/were ever intended to be called manually, we can now enforce this with modern class-features.
|
/botio unittest |
From: Bot.io (Linux m4)ReceivedCommand cmd_unittest from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.241.84.105:8877/afdb424229e43b0/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_unittest from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.193.163.58:8877/d2f6f1d4f1d218c/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.241.84.105:8877/afdb424229e43b0/output.txt Total script time: 3.04 mins
|
From: Bot.io (Windows)FailedFull output at http://54.193.163.58:8877/d2f6f1d4f1d218c/output.txt Total script time: 6.12 mins
|
|
/botio integrationtest |
From: Bot.io (Windows)ReceivedCommand cmd_integrationtest from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.193.163.58:8877/4d51498f9569d5f/output.txt |
From: Bot.io (Linux m4)ReceivedCommand cmd_integrationtest from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.241.84.105:8877/71f12f48d5010dd/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.241.84.105:8877/71f12f48d5010dd/output.txt Total script time: 3.97 mins
|
From: Bot.io (Windows)SuccessFull output at http://54.193.163.58:8877/4d51498f9569d5f/output.txt Total script time: 6.42 mins
|
|
Looks good to me! |
Slightly simplify the
PDFFindController._extractTextmethodCurrently we're resolving the Promises in the
_extractTextPromisesArray with the page-index, despite that not really being necessary since the Promises in the Array are explicitly inserted in the correct order.Furthermore, we can replace the standard
for-loop with afor...of-loop which results in ever so slightly more compact code.Convert all "private" methods in
PDFFindControllerinto proper onesGiven that none of these methods are/were ever intended to be called manually, we can now enforce this with modern class-features.