Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace XMLHttpRequest usage with the Fetch API in send (in test/unit/testreporter.js) #14654

Merged
merged 1 commit into from
Mar 11, 2022

Conversation

Snuffleupagus
Copy link
Collaborator

Besides converting the send function to use the Fetch API, this patch also changes the method to return a Promise to get rid of the callback function. (Although, currently there's no call-site passing in a callback function.)

…nit/testreporter.js`)

Besides converting the `send` function to use the Fetch API, this patch also changes the method to return a `Promise` to get rid of the callback function. (Although, currently there's no call-site passing in a callback function.)
@Snuffleupagus
Copy link
Collaborator Author

/botio unittest

@pdfjsbot
Copy link

From: Bot.io (Linux m4)


Received

Command cmd_unittest from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.241.84.105:8877/12f19969fcac0d7/output.txt

@pdfjsbot
Copy link

From: Bot.io (Windows)


Received

Command cmd_unittest from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.193.163.58:8877/879d0bdd3e6219e/output.txt

@pdfjsbot
Copy link

From: Bot.io (Linux m4)


Success

Full output at http://54.241.84.105:8877/12f19969fcac0d7/output.txt

Total script time: 3.07 mins

  • Unit Tests: Passed

@pdfjsbot
Copy link

From: Bot.io (Windows)


Success

Full output at http://54.193.163.58:8877/879d0bdd3e6219e/output.txt

Total script time: 6.77 mins

  • Unit Tests: Passed

@Snuffleupagus
Copy link
Collaborator Author

/botio fonttest

@pdfjsbot
Copy link

From: Bot.io (Linux m4)


Received

Command cmd_fonttest from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.241.84.105:8877/7a4d0eb1e5ec8fe/output.txt

@pdfjsbot
Copy link

From: Bot.io (Windows)


Received

Command cmd_fonttest from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.193.163.58:8877/f8bb331507c0642/output.txt

@pdfjsbot
Copy link

From: Bot.io (Linux m4)


Success

Full output at http://54.241.84.105:8877/7a4d0eb1e5ec8fe/output.txt

Total script time: 1.55 mins

  • Font Tests: Passed

@pdfjsbot
Copy link

From: Bot.io (Windows)


Success

Full output at http://54.193.163.58:8877/f8bb331507c0642/output.txt

Total script time: 3.09 mins

  • Font Tests: Passed

@timvandermeij timvandermeij merged commit 0d265a3 into mozilla:master Mar 11, 2022
@timvandermeij
Copy link
Contributor

Thank you for improving this!

@Snuffleupagus Snuffleupagus deleted the TestReporter-send-fetch branch March 11, 2022 21:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants