-
Notifications
You must be signed in to change notification settings - Fork 10.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace XMLHttpRequest usage with the Fetch API in send
(in test/unit/testreporter.js
)
#14654
Replace XMLHttpRequest usage with the Fetch API in send
(in test/unit/testreporter.js
)
#14654
Conversation
…nit/testreporter.js`) Besides converting the `send` function to use the Fetch API, this patch also changes the method to return a `Promise` to get rid of the callback function. (Although, currently there's no call-site passing in a callback function.)
/botio unittest |
From: Bot.io (Linux m4)ReceivedCommand cmd_unittest from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.241.84.105:8877/12f19969fcac0d7/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_unittest from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.193.163.58:8877/879d0bdd3e6219e/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.241.84.105:8877/12f19969fcac0d7/output.txt Total script time: 3.07 mins
|
From: Bot.io (Windows)SuccessFull output at http://54.193.163.58:8877/879d0bdd3e6219e/output.txt Total script time: 6.77 mins
|
/botio fonttest |
From: Bot.io (Linux m4)ReceivedCommand cmd_fonttest from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.241.84.105:8877/7a4d0eb1e5ec8fe/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_fonttest from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.193.163.58:8877/f8bb331507c0642/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.241.84.105:8877/7a4d0eb1e5ec8fe/output.txt Total script time: 1.55 mins
|
From: Bot.io (Windows)SuccessFull output at http://54.193.163.58:8877/f8bb331507c0642/output.txt Total script time: 3.09 mins
|
Thank you for improving this! |
Besides converting the
send
function to use the Fetch API, this patch also changes the method to return aPromise
to get rid of the callback function. (Although, currently there's no call-site passing in a callback function.)